Sergey Gotliv has posted comments on this change. Change subject: deactivateSD - perform nothing if the domain is already deactivated ......................................................................
Patch Set 1: (1 comment) .................................................... File vdsm/storage/sp.py Line 1143: Line 1144: if sdUUID not in domList: Line 1145: raise se.StorageDomainNotInPool(self.spUUID, sdUUID) Line 1146: Line 1147: if domList[sdUUID] == sd.DOM_ATTACHED_STATUS: 1. -1 is for silent ignore. 2. This patch assumes that if domain status is attached that someone already updated monitoring threads and another update is not needed, right? I just asked to check that assumption Line 1148: return True Line 1149: Line 1150: try: Line 1151: dom = sdCache.produce(sdUUID) -- To view, visit http://gerrit.ovirt.org/22343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I927557637cc6588dae832427018f6ac304f0a562 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
