Yaniv Bronhaim has posted comments on this change. Change subject: upgrade.log now owned by vdsm:kvm ......................................................................
Patch Set 3: -Code-Review (1 comment) .................................................... File lib/vdsm/tool/upgrade.py Line 60: disable_existing_loggers=False) Line 61: uid = pwd.getpwnam(VDSM_USER)[2] Line 62: gid = grp.getgrnam(VDSM_GROUP)[2] Line 63: cmd = [EXT_CHOWN, "%s:%s" % (uid, gid), Line 64: os.path.join(P_VDSM_LOG, 'upgrade.log')] ohh you run it as sudo=True.. you cheater ... so my comments are irrelevant. but this is an hack that I'm so we can find better way Line 65: (rc, out, err) = execCmd(cmd, sudo=True) Line 66: if rc != 0: Line 67: raise IOError(err) Line 68: except Exception: -- To view, visit http://gerrit.ovirt.org/22349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2fb887fa6d43f2b35f4a07927026baa746e7a41 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
