Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: add node registration tool ......................................................................
Patch Set 4: (2 comments) .................................................... File lib/vdsm/tool/ovirt-node-registration.py Line 1: # Copyright (C) 2012-2013 Red Hat, Inc. The file is most useful on ovirt-node, but it may be helpful elsewhere. How about naming it as the verb, "register.py"? Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by Line 5: # the Free Software Foundation; version 2 of the License. Line 272: help='Add ovirt engine public ssh key to node authorized keys', Line 273: ) Line 274: Line 275: parser.add_argument( Line 276: '--enable-log', We can still use the logging module even if we opt for stdout. -v can set the logging level. Line 277: action='store_true', Line 278: help="Creates a log file during the execution" Line 279: ) Line 280: -- To view, visit http://gerrit.ovirt.org/22494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b508d2a365108950c0758134a6d9c024d04f2c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
