Dan Kenigsberg has posted comments on this change.
Change subject: linkmonitor: fix reported device name of vlans and macvlans
......................................................................
Patch Set 12: Code-Review-1
(1 comment)
....................................................
File lib/vdsm/ipwrapper.py
Line 578: line = line[len(cls._DELETED_TEXT):]
Line 579:
Line 580: ifindex, devName, data = [el.strip() for el in
line.split(':', 2)]
Line 581: if (state != cls.LINK_STATE_DELETED and
Line 582: not _dev_sysfs_exists(devName)):
Instead of this, please assume that anything reported with an "@" sign is a
vlan device, and scrap the part following the @. Add a big fat warning with a
link to the iproute2 bug - we shouldn't be holier than the pope.
Line 583: # devName is probably a vlan device with an
'@underlying_dev'
Line 584: # affixed or it might refer to a just deleted link.
Line 585: try:
Line 586: devName = _dev_by_index(ifindex)
--
To view, visit http://gerrit.ovirt.org/22061
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieaeab6adc30a80b70e9e967768c10b3fea65aa16
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
