Dan Kenigsberg has posted comments on this change.
Change subject: vmfex: Add vmfex device custom properties hook
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
....................................................
File vdsm_hooks/vmfex_dev/vmfex_vnic.py
Line 41: """Scans the system for physical nics that have zeroes as MAC
address,
Line 42: as they will be the free VFs that can be used with the hook."""
Line 43: nics = []
Line 44: for path, dirnames, filenames in os.walk('/sys/devices/',
topdown=True):
Line 45: if path == '/sys/devices/':
trimming these paths ahead of time is not sooo important, but let it be.
Line 46: for badDir in [d for d in dirnames if not
d.startswith('pci')]:
Line 47: dirnames.remove(badDir)
Line 48: if 'address' in filenames:
Line 49: with open(os.path.join(path, 'address')) as addrFile:
--
To view, visit http://gerrit.ovirt.org/22529
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I830e37c1f3163e7e80bf3c568ff3a06136c39e13
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Dan Yasny <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
