Dan Kenigsberg has submitted this change and it was merged. Change subject: fileSD: Fix image deletion on gluster domain ......................................................................
fileSD: Fix image deletion on gluster domain getImagePath() does not work for glusterSD. The problem is caused by that domaindir's base paths of glusterSD and other file-based SD are not the same. For glusterSD, it's sd.storage_repository/mnt/glusterSD, while it's sd.storage_repository/mnt/ for other file-based storage domains. This makes the deletion fail on gluster domain. With this patch we use the storage domain's domaindir to get the image's directory correctly. Reference: * http://lists.ovirt.org/pipermail/users/2013-December/018653.html Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Signed-off-by: huntxu <mhun...@gmail.com> Reviewed-on: http://gerrit.ovirt.org/22359 Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Federico Simoncelli <fsimo...@redhat.com> Tested-by: Nir Soffer <nsof...@redhat.com> --- M vdsm/storage/fileSD.py 1 file changed, 4 insertions(+), 18 deletions(-) Approvals: Nir Soffer: Verified; Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
