Dan Kenigsberg has posted comments on this change. Change subject: vm: janitorial: factorize key deletion in Vm.conf ......................................................................
Patch Set 2: Indeed, "recovery" should never have been in conf. And the current message, when the same "create" code path is used for 4 slightly different flows (new vm, recovery, migration destination, dehibernation) adds too much overcomplexity. I'm less sure about pauseReason. Until we find a way to re-read it from libvirt on startup, we'd better persist it somewhere. -- To view, visit http://gerrit.ovirt.org/22556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5a3da3fea0346f5f75c2f9d60c995aaf7214c6d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
