Francesco Romani has posted comments on this change.
Change subject: tests: janitorial: cleanup temporary directories
......................................................................
Patch Set 4:
(1 comment)
....................................................
File tests/hooksTests.py
Line 101: os.unlink(sName)
Line 102: self.assertEqual({'md5': md5}, info)
Line 103:
Line 104: @contextmanager
Line 105: def _namedTemporaryDir(self):
It could be useful in mountTests.py. The other tests which need a temporary
directory
already do proper cleanup (e.g. using setUp/tearDown).
However, because working with temp dirs is such a common task, I'm inclined to
move it anyway in testrunner for greater visibility (so hopefully avoid future
code duplication).
Moreover, the change in mountTests.py is trivial, so I'll change that too.
Line 106: tmpDir = tempfile.mkdtemp()
Line 107: try:
Line 108: yield tmpDir
Line 109: finally:
--
To view, visit http://gerrit.ovirt.org/22377
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6581771479de9f72360ea537de32abcdad496b3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
