Federico Simoncelli has posted comments on this change.
Change subject: sp: improve masterMigrate safety
......................................................................
Patch Set 3:
(1 comment)
....................................................
File vdsm/storage/sp.py
Line 869: newmsd.changeRole(sd.MASTER_DOMAIN)
Line 870: self.switchMasterDomain(curmsd, newmsd, masterVersion)
Line 871: except Exception:
Line 872: self.log.exception('migration to new master failed')
Line 873: newmsd.unmountMaster()
The original exception is not lost because we use self.log.exception in line
872. In unmountMaster there are two checks that will avoid failures if the
master is not mounted:
try:
masterMount = mount.getMountFromTarget(masterdir)
except OSError as ex:
if ex.errno == errno.ENOENT:
return
...
if masterMount.isMounted():
...
Line 874: newmsd.releaseClusterLock()
Line 875: raise
Line 876:
Line 877: # From this point on we have a new master and should not fail
--
To view, visit http://gerrit.ovirt.org/22419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I155b36d41df43230f99ba610699bba05bee3f0c0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
