Federico Simoncelli has posted comments on this change.
Change subject: sp: split metadata transaction in createMaster
......................................................................
Patch Set 4:
(1 comment)
Continuing on patch set 4
....................................................
File vdsm/storage/sp.py
Line 695: self.stopMonitoringDomains()
Line 696: return True
Line 697:
Line 698: @unsecured
Line 699: def initMasterDomain(self, poolName, domain, masterVersion):
I just remembered that it would be better also not to mention the metadata as
this is an API that should be implemented (mostly noop) also from the new
backend (without metadata). Any idea?
initPool / initializePool / createPool (all ugly as they have "Pool" in the
name).
Line 700: self._getPoolMD(domain).update({
Line 701: PMDK_SPM_ID: SPM_ID_FREE,
Line 702: PMDK_LVER: LVER_INVALID,
Line 703: PMDK_MASTER_VER: masterVersion,
--
To view, visit http://gerrit.ovirt.org/22418
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b22af92b1f9a481be9af844b1acc47ae513d078
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
