Francesco Romani has posted comments on this change. Change subject: vdsm: prepareVolumePath payload misdetection fix ......................................................................
Patch Set 1: (2 comments) .................................................... Commit Message Line 9: The changeset http://gerrit.ovirt.org/#/c/22324/3 Line 10: used a condition too broad for its check, causing Line 11: a device path misdetection when cloud-init is used. Line 12: Line 13: This in turn makes vdsm to produce an invalid xml I agree it could be put down in a better way. Maybe it is better to quote https://bugzilla.redhat.com/show_bug.cgi?id=1047356#c9 as you suggest below. Line 14: with duplicate cdrom IDs, culminating in a qemu Line 15: failure at start. Line 16: Line 17: See the buzilla linked below for a full description Line 13: This in turn makes vdsm to produce an invalid xml Line 14: with duplicate cdrom IDs, culminating in a qemu Line 15: failure at start. Line 16: Line 17: See the buzilla linked below for a full description OK, Will update. On this topic: you think it is better fixed the way it is now or the way it is in the comment linked above? Line 18: of a misbehaviour. Line 19: Line 20: This patch provides a band-aid fix to the issue Line 21: by tightening the prepareVolumePath check. -- To view, visit http://gerrit.ovirt.org/22925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie847eb92f28d24f4d8189e03a47cd64cc6597363 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
