Nir Soffer has posted comments on this change. Change subject: hsm: Rescan multipath before loading lvm cache ......................................................................
Patch Set 3: > Actually the race doesn't exist since sdCache.refreshStorage calls > lvm.invalidateCache so calling: lvm.bootstrap lvm.invalidateCache by > definition means that we'll have redundant lvm calls. I did not say there is a race - the issue (as explained in the commit message), is that we first load lvm data, then invalidate lvm data, and call multipath.resscan. So we just waste time loading lvm data twice, once before multipath.rescan, and one more at the first time lvm data is needed after multipath.rescan. > The only question I have is whether we can just drop the bootstrap call > (since effectively this has been the behaviour up until now). We always called bootstrap. The difference is we used to call lvm._lvminfo.bootstrap() (accessing private module data) before, and now we call lvm.boostrap which is a public method. And of course lvm.bootstrap is responsible for deactivating active lvs, so I don't see how we can drop it. -- To view, visit http://gerrit.ovirt.org/21567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ec7beee1db193a47d9e8109929badfd5b322c02 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
