Adam Litke has posted comments on this change.
Change subject: dump the core of a VM
......................................................................
Patch Set 14: Code-Review-1
(1 comment)
I propose some changes to the vdsm API for this command.
....................................................
File vdsm_api/vdsmapi-schema.json
Line 5549: #
Line 5550: ##
Line 5551: {'command': {'class': 'VM', 'name': 'coreDump'},
Line 5552: 'data': {'to': 'str', 'params': 'DumpParams'}}
Line 5553:
I don't see any value in wrapping some parameters into a params dict while
leaving the 'to' param on the command line. How about specifying all arguments
to the command directly:
{'command': {'class': 'VM', 'name': 'coreDump'},
5552 + 'data': {'to': 'str', 'post-action': 'CoreDumpPostAction', 'flags':
'CoreDumpFlags'}}
Line 5554: ##
Line 5555: # @VM.monitorCommand:
Line 5556: #
Line 5557: # Send a command to the qemu monitor.
--
To view, visit http://gerrit.ovirt.org/7329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4aac9e747dc7aa64a6ff5ef256a7a4375aa2bb5
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Better Saggi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
