Federico Simoncelli has posted comments on this change. Change subject: securable: refactor the securable implementation ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/22115/2/vdsm/storage/securable.py File vdsm/storage/securable.py: Line 43: setattr(f, SECURE_FIELD, False) Line 44: return f Line 45: Line 46: Line 47: def secure_method(method): > Were there any talks about it? We always introduced changes gradually with new patches. I prefer underscores and anyway this module is completely unrelated to VDSM (and it doesn't even belong to storage). Moreover the method in question is used only internally and it's never called from outside (do you prefer _secure_method)? If you still think that this is going to break VDSM consistency I'll change it. Line 48: def wrapper(self, *args, **kwargs): Line 49: if not hasattr(self, "__securable__"): Line 50: raise RuntimeError("Secured object is not a securable") Line 51: -- To view, visit http://gerrit.ovirt.org/22115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5a8be7536748481746795e27701fbecc7c3318c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
