Oved Ourfali has posted comments on this change. Change subject: volume: changing un-shared treatment in the share function ......................................................................
Patch Set 6: Verified+1 Verified by running VM creation from a regular template, and from a glance template (which causes the "setShared" to be called). Did what you suggested (well, at least I think I did what you suggested :-) ). I still think that the original fix has less potential for additional issues... for some reason changing the createVolume function is more scary for me :-) Let me know what you think, and let's merge something today. -- To view, visit http://gerrit.ovirt.org/23260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9a4b84795b176b9696684045e9774d324a42eca Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
