Dan Kenigsberg has posted comments on this change. Change subject: caps: check availability abort on EIO in libvirt ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23273/4/vdsm/caps.py File vdsm/caps.py: Line 398: # that flag, even though it should be present since 1.0.1. Line 399: if hasattr(libvirt, 'VIR_MIGRATE_ABORT_ON_ERROR'): Line 400: return dsaversion.version_info Line 401: Line 402: from distutils.version import StrictVersion as version Is there a reason for the "as"? The renaming has confused me for a moment, and worried what is this unknown "version()" function. Unless an identified is used often, or there's a collision of names, it's better to use its standard name. Line 403: # Workaround: we drop the cluster 3.4+ Line 404: # compatibility when we run on top of Line 405: # a libvirt without this flag. Line 406: info = dsaversion.version_info.copy() -- To view, visit http://gerrit.ovirt.org/23273 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dd857ac3c00c48d4de3a50931cb259f45ff4f5d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
