Ayal Baron has posted comments on this change. Change subject: sp: fix pool membership check in attachSD ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/23446/2/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 869: sdCache.invalidateStorage() Line 870: dom = sdCache.produce(sdUUID) Line 871: Line 872: try: Line 873: self.validateAttachedDomain(dom) the only thing I don't like is that validate expects it to be there so it gets the domain md (possibly goes to disk) and if the pool is not there it invalidates the md and checks again, but attach flow is pretty rare anyway and this is not the long part of it so no big deal Line 874: except (se.StorageDomainNotMemberOfPool, se.StorageDomainNotInPool): Line 875: pass # domain is not attached to this pool yet Line 876: else: Line 877: log.warning('domain %s is already attached to pool %s', -- To view, visit http://gerrit.ovirt.org/23446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4169ddcb4da29c8b806b5788080c16349b642197 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
