Nir Soffer has posted comments on this change. Change subject: MonkeyPatch: fix applying and reverting (static|class)methods. ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/23378/5/tests/monkeypatch.py File tests/monkeypatch.py: Line 63: old = getattr(module, name) Line 64: self.old.append((module, name, old)) Line 65: # The following block is done so that if it is a method we are Line 66: # patching in, that it will have the same type as the method it Line 67: # replaced. Is this required for both python3 and 2? Line 68: if inspect.isclass(module): Line 69: if inspect.isfunction(old): Line 70: that = staticmethod(that) Line 71: elif (inspect.ismethod(old) and -- To view, visit http://gerrit.ovirt.org/23378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3100455ab761481f57a93ab8aacc34ac4ab91eb Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
