Antoni Segura Puimedon has posted comments on this change. Change subject: introducing downloadFromStream verb ......................................................................
Patch Set 5: Code-Review-1 (3 comments) Some minor nits. http://gerrit.ovirt.org/#/c/23281/5/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 43: _glusterEnabled = False Line 44: Line 45: Line 46: class BindingXMLRPC(object): Line 47: Adding this blank line is just noise in the git diff. Line 48: def __init__(self, cif, log, ip, port, ssl, vds_resp_timeout, Line 49: trust_store_path, default_bridge): Line 50: self.cif = cif Line 51: self.log = log Line 151: return basehandler.setup(self) Line 152: Line 153: def do_PUT(self): Line 154: try: Line 155: ctype, pt = cgi.parse_header(self.headers.getheader( ctype(s) has a very specific python meaning that differs by leaps and bounds from the semantics of this variable. I'd very much recommend naming it contentType. Line 156: self.HEADER_CONTENT_TYPE)) Line 157: if ctype != 'application/octet-stream': Line 158: self.send_error(httplib.UNSUPPORTED_MEDIA_TYPE, Line 159: "unsupported content type: %r" % ctype) Line 153: def do_PUT(self): Line 154: try: Line 155: ctype, pt = cgi.parse_header(self.headers.getheader( Line 156: self.HEADER_CONTENT_TYPE)) Line 157: if ctype != 'application/octet-stream': this literal should probably be also a constant. Line 158: self.send_error(httplib.UNSUPPORTED_MEDIA_TYPE, Line 159: "unsupported content type: %r" % ctype) Line 160: return Line 161: -- To view, visit http://gerrit.ovirt.org/23281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I768b84799ed9fb2769c6d4240519d036f8988b99 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
