Federico Simoncelli has posted comments on this change. Change subject: stats: report detailed VM down status ......................................................................
Patch Set 4: Code-Review+1 (3 comments) http://gerrit.ovirt.org/#/c/22631/4/vdsm/vm.py File vdsm/vm.py: Line 233: Line 234: def _finishSuccessfully(self): Line 235: self.status['progress'] = 100 Line 236: if self._mode != 'file': Line 237: self._vm.setDownStatus(NORMAL, "Migration succeeded") You probably want a code for this as well (so that it can be internationalized). Line 238: self.status['status']['message'] = 'Migration done' Line 239: else: Line 240: # don't pickle transient params Line 241: for ignoreParam in ('displayIp', 'display', 'pid'): Line 248: pickle.dump(self._machineParams, f) Line 249: finally: Line 250: self._vm.cif.teardownVolumePath(self._dstparams) Line 251: Line 252: self._vm.setDownStatus(NORMAL, "SaveState succeeded") Same, etc... Line 253: self.status['status']['message'] = 'SaveState done' Line 254: Line 255: def _patchConfigForLegacy(self): Line 256: """ Line 1746: m.appendChildWithArgs('target', type='virtio', port='0') Line 1747: return m Line 1748: Line 1749: Line 1750: class DownErrorCode: You probably want this also for regular messages (not error only). You could rename it to DownMessageCode. Line 1751: Success = 0 Line 1752: GenericError = 1 Line 1753: LostQEMUConnection = 2 Line 1754: LibvirtStartFailed = 3 -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
