Dan Kenigsberg has posted comments on this change. Change subject: vdsm.spec: vdsm should own metadata supervdsm logs ......................................................................
Patch Set 1: Code-Review-1 (2 comments) /var/log/vdsm/mom.log is created by the mom module of the vdsm process, and should be owned by this rpm too. http://gerrit.ovirt.org/#/c/23754/1/vdsm.spec.in File vdsm.spec.in: Line 614: # VDSM Log Line 615: install -dDm 0755 %{buildroot}@VDSMLOGDIR@ Line 616: # Avoid rpmbuild complain about files that doesn't exist during the build Line 617: touch %{buildroot}@VDSMLOGDIR@/metadata.log Line 618: touch %{buildroot}@VDSMLOGDIR@/supervdsm.log Please post a followup patch that does this in Make file. Line 619: touch %{buildroot}@VDSMLOGDIR@/vdsm.log Line 620: Line 621: # Install the respawn utility Line 622: install -Dm 0755 init/sysvinit/respawn \ Line 882: %endif Line 883: Line 884: %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@ Line 885: %ghost %config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/metadata.log Line 886: %ghost %config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/supervdsm.log supervdsm.log must be owned by root. Any chance for shorter lines here? Line 887: %ghost %config %attr(0644, %{vdsm_user}, %{vdsm_group}) @VDSMLOGDIR@/vdsm.log Line 888: %ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/hsm-tasks Line 889: %ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/mnt Line 890: %dir %{_libexecdir}/%{vdsm_name} -- To view, visit http://gerrit.ovirt.org/23754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2776b8518930393b281a1885268813f8d4d7c85b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
