Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Determine bootproto from dhclient's lease files ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/23098/16/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 566: Line 567: interfaces = set() Line 568: insideLease = False Line 569: Line 570: for line in leaseFile.readlines(): > I have chosen this approach while examining dhclient's source code which us Ok, let us keep it that way, for now. Line 571: if insideLease: Line 572: if line.startswith(IFACE) and line.endswith(IFACE_END): Line 573: name = line[len(IFACE):-len(IFACE_END)] Line 574: -- To view, visit http://gerrit.ovirt.org/23098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fbc48a0adf5f40120a72ec2c4cc2fc80b7226b8 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
