Martin Polednik has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/19389/5/vdsm/API.py File vdsm/API.py: Line 357: stats = v.getStats().copy() Line 358: stats['vmId'] = self._UUID Line 359: return {'status': doneCode, 'statsList': [stats]} Line 360: Line 361: def wakeup(self): > From the point of view of VDSM the VM will be still running (qemu process). I've spoken to Michal about this: adding new state is not desired, therefore I'm left to work the state 'paused'. Discovery should be based on whether the engine currently handles state such as hibernation on its side or relies on VDSM: if it's on engine side, we only need to change the state internally based on response of API calls. If we depend solely on what VDSM reports, I propose adding states 'S3' and 'S4' and I'd look into mechanism of discovering these on recovery. Line 362: try: Line 363: v = self._cif.vmContainer[self._UUID] Line 364: response = v.pmWakeup() Line 365: except KeyError: Line 365: except KeyError: Line 366: return errCode['noVM'] Line 367: return response Line 368: Line 369: def hibernate(self, target): > This behaves like shutdown. Should it become an additional option for shutd The verb 'hibernate' already exists (for our migrate to file 'hibernate'). Line 370: """ Line 371: Hibernate a VM. Line 372: Line 373: :param mode: mem/disk/hybrid/hiberVolHandle -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Better Saggi <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
