Dan Kenigsberg has posted comments on this change. Change subject: vm: discover volume path from xml definition ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/24202/1//COMMIT_MSG Commit Message: Line 22: domain Line 23: Line 24: In this patch: Line 25: Line 26: - revert to the previous path for virtual machine images Is this really necessary? could you explain why? I think that the former change was not inadvertent - it was an attempt to remove a reference to the pool. Line 27: - inspect libvirt xml during live migration and vdsm restart to Line 28: identify if it is necessary to update the path cached in the Line 29: drive object (provided by prepareImage) Line 30: http://gerrit.ovirt.org/#/c/24202/1/vdsm/vm.py File vdsm/vm.py: Line 4980: d.address = address Line 4981: d.readonly = readonly Line 4982: if bootOrder: Line 4983: d.bootOrder = bootOrder Line 4984: self.log.debug('Matched %s', mergeDicts(deviceDict, d)) imo, the previous added block would have been slightly more readable on an "elif" block here. Line 4985: # Update vm's conf with address for known disk devices Line 4986: knownDev = False Line 4987: for dev in self.conf['devices']: Line 4988: # See comment in previous loop. This part is used to update -- To view, visit http://gerrit.ovirt.org/24202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I322f1f879fbd5b6415789f3b307e8741d846d694 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
