Dan Kenigsberg has posted comments on this change. Change subject: vm: Require format attribute for drives ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24234/1/vdsm/vm.py File vdsm/vm.py: Line 1441: VOLWM_FREE_PCT = 100 - config.getint('irs', 'volume_utilization_percent') Line 1442: VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during replication Line 1443: Line 1444: def __init__(self, conf, log, **kwargs): Line 1445: if 'format' not in kwargs: > This is too complicated and has too much heuristics. Do you see any reason And most importantly, for base images guessing the format is a known security problem (the owner of a VM with raw format can mess with his image too look like a qcow, and gain read/write on any other image on next boot). Line 1446: raise InvalidDeviceParameters('"format" attribute is required:' Line 1447: ' %r' % kwargs) Line 1448: if not kwargs.get('serial'): Line 1449: self.serial = kwargs.get('imageID'[-20:]) or '' -- To view, visit http://gerrit.ovirt.org/24234 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01ab1e071ecb76f383cc6dc7d99782e10cc90136 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Meital Bourvine <[email protected]> Gerrit-Reviewer: Meital bourvine <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
