Francesco Romani has posted comments on this change. Change subject: caps: Collect numa information ......................................................................
Patch Set 4: (2 comments) Just a couple of things in the commit message and it is good for me. http://gerrit.ovirt.org/#/c/23703/4//COMMIT_MSG Commit Message: Line 8: Line 9: This patch modifies the caps module to add function of collect Line 10: host numa information and report to ovirt engine. Line 11: It will add a key named numaNodes in the xml rpc response of Line 12: getCapabilities whose value is the host's numa information. Add one blank line here for readability, please. Line 13: An example of the value: 0:0,1:10240:9500;1:2,3:10240:9700 Line 14: The items are separated by semicolon, the fields in each item Line 15: are separated by colon. Line 16: Take the first item above to explain the meaning of each field: Line 14: The items are separated by semicolon, the fields in each item Line 15: are separated by colon. Line 16: Take the first item above to explain the meaning of each field: Line 17: 0 - The index of numa node Line 18: 0,1 - The index of cpu which belong to this numa node Thanks, we're almost there. Is this socket_id,core_id? If so, I'd change the text as something like that The index of cpu (socket, core) which belong to this numa node. Line 19: 10240 - The total memory of this numa node Line 20: 9500 - The free memory of this numa node Line 21: Line 22: Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd -- To view, visit http://gerrit.ovirt.org/23703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63eeb697ab986c3b9cad0dc44f41924f329e52cd Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
