Antoni Segura Puimedon has posted comments on this change. Change subject: vdsm: Enable config of VM serial number ......................................................................
Patch Set 1: (1 comment) proposing different parameter name for clarity. http://gerrit.ovirt.org/#/c/24274/1/vdsm/vm.py File vdsm/vm.py: Line 1013: Line 1014: if self.arch == caps.Architecture.X86_64: Line 1015: oselem.appendChildWithArgs('smbios', mode='sysinfo') Line 1016: Line 1017: def appendSysinfo(self, osname, osversion, serial): I'd rather have serialNumber than serial. Line 1018: """ Line 1019: Add <sysinfo> element to domain: Line 1020: Line 1021: <sysinfo type="smbios"> -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76309e833f0b00e69a187037a415642a8daf35f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
