Hello Ayal Baron, Nir Soffer, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/24467
to review the following change.
Change subject: clientIF: Teardown volume path only for VDSM images
......................................................................
clientIF: Teardown volume path only for VDSM images
Trying to tear down a cdrom or external lun throws an exception which
creates a lot of log printings.
Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Bug-Url: https://bugzilla.redhat.com/980054
Signed-off-by: Sergey Gotliv <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/21973
Reviewed-by: Nir Soffer <[email protected]>
Reviewed-by: Ayal Baron <[email protected]>
Reviewed-by: Allon Mureinik <[email protected]>
---
M vdsm/clientIF.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/24467/1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 67dacab..1d3b0a4 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -323,9 +323,10 @@
def teardownVolumePath(self, drive):
res = {'status': doneCode}
try:
- res = self.irs.teardownImage(drive['domainID'],
- drive['poolID'], drive['imageID'])
- except (KeyError, TypeError):
+ if vm.isVdsmImage(drive):
+ res = self.irs.teardownImage(drive['domainID'],
+ drive['poolID'], drive['imageID'])
+ except TypeError:
# paths (strings) are not deactivated
if not isinstance(drive, basestring):
self.log.warning("Drive is not a vdsm image: %s",
--
To view, visit http://gerrit.ovirt.org/24467
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I041a306636c75a7aa37d4d7c0811366d80fe609c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
