Nir Soffer has posted comments on this change. Change subject: vm: recover must finish with libvirt connection ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/24423/6//COMMIT_MSG Commit Message: Line 8: Line 9: bz106336 highlights an scenario on which a Vm can Line 10: go Up without a proper libvirt connection established (_dom Line 11: attribute initialized), and this lead to an out-of-sync Line 12: status which is very bad. Please explain how this is very bad: ... and this can lead to a running vm which is reported as not running by vdsm. Engine may start another instance of the vm on another host, which will probably cause data corruption when two vm are writing to the same disk. Line 13: Line 14: Description of the scenario: Line 15: * while VM is running, storage becomes blocked or not responding. Line 16: * the user restarts VDSM while the storage is still blocked. -- To view, visit http://gerrit.ovirt.org/24423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c33a62c29fc70170b6f802a20b6016b301e96de Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
