Antoni Segura Puimedon has posted comments on this change. Change subject: Fix defaultRoute handling ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24631/2/vdsm/configNetwork.py File vdsm/configNetwork.py: Line 278: Line 279: netEnt = objectivizeNetwork(network if bridged else None, vlan, bonding, Line 280: bondingOptions, nics, mtu, ipaddr, netmask, Line 281: gateway, bootproto, ipv6addr, ipv6gateway, Line 282: defaultRoute=defaultRoute, _netinfo=_netinfo, > Perhaps it would be more clear to provide None for the ipv6addr and ipv6gat I'm all for that, but we can do it in a follow up patch. Line 283: configurator=configurator, **options) Line 284: Line 285: netEnt.configure(**options) Line 286: configurator.configureLibvirtNetwork(network, netEnt, -- To view, visit http://gerrit.ovirt.org/24631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
