Hello Antoni Segura Puimedon, Assaf Muller,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/24677
to review the following change.
Change subject: Fix defaultRoute handling
......................................................................
Fix defaultRoute handling
defaultRoute wasn't being past correctly to objectivizeNetwork,
so that defaultRoute was always None inside the function,
no matter what was past to it.
This meant that DEFROUTE=yes/no was never written to ifcfg files,
and 'ip route add default...' never applied by the iproute2
configurator.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1015009
Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d
Signed-off-by: Assaf Muller <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/24631
Reviewed-by: Antoni Segura Puimedon <[email protected]>
Reviewed-by: Dan Kenigsberg <[email protected]>
Tested-by: Dan Kenigsberg <[email protected]>
---
M vdsm/configNetwork.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/24677/1
diff --git a/vdsm/configNetwork.py b/vdsm/configNetwork.py
index 2be811c..78b5012 100755
--- a/vdsm/configNetwork.py
+++ b/vdsm/configNetwork.py
@@ -279,7 +279,7 @@
netEnt = objectivizeNetwork(network if bridged else None, vlan, bonding,
bondingOptions, nics, mtu, ipaddr, netmask,
gateway, bootproto, ipv6addr, ipv6gateway,
- defaultRoute, _netinfo=_netinfo,
+ defaultRoute=defaultRoute, _netinfo=_netinfo,
configurator=configurator, **options)
netEnt.configure(**options)
--
To view, visit http://gerrit.ovirt.org/24677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I643c5fe9dab39833d73541b7a1bfaae9ae3e749d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
