Federico Simoncelli has posted comments on this change. Change subject: avoid redundant domain produce() in createStoragePool ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/7347/3/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 619: spUUIDs = domain.getPools() Line 620: # Non ISO domains have only 1 pool Line 621: if len(spUUIDs) > 0: Line 622: raise se.StorageDomainAlreadyAttached(spUUIDs[0], sdUUID) Line 623: domains.append(domain) minor: you can consider to cache only the data domains eventually: dataDomains.append(domain) ... for domain in dataDomains: if domain.getVersion() != msdVersion: ... anyway I don't want think we should block on this. Line 624: Line 625: for domain in domains: Line 626: if domain.isData() and (domain.getVersion() != msdVersion): Line 627: raise se.MixedSDVersionError(domain.sdUUID, -- To view, visit http://gerrit.ovirt.org/7347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1c236aa3043068ca8f3f376cb340e986cd484bb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
