Nir Soffer has posted comments on this change. Change subject: netlink: Introduce socket pool ......................................................................
Patch Set 3: > For your second point, I do not see a real contention issue, at least not one > that is justifying creation of multiple socket pools. I did not check the usage of these sockets, but from my talk with Antoni, I understand that we need the socket for sampling, running every (2?) seconds for very short time, and for network operations, that can do 100's of requests with a socket. So it would be nice if the sampling thread has its own socket, so it never be delayed by long network operation. We can keep another socket, or a pool of sockets for random network operations. If we don't care about delaying the sampling thread from time to time, then a pool can good solution. -- To view, visit http://gerrit.ovirt.org/24603 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I657ac3d3e0c2661ce73bdef9aa807ead888a42eb Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
