Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/24898

to review the following change.

Change subject: Reload daemon file after each install
......................................................................

Reload daemon file after each install

Currently we load the daemon file only on first install. After upgrade
we could fail with:
"Warning: Unit file changed on disk, 'systemctl --system daemon-reload'
recommended."

This patch perform the reload after each installation of vdsm.

Change-Id: I1d6e6e292494da78052a9593c5cbe94ac35ea0d9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063772
Signed-off-by: Yaniv Bronhaim <ybron...@redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24535
Reviewed-by: Dan Kenigsberg <dan...@redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/24898/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 149793e..a90d1a4 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -725,8 +725,8 @@
 if [ "$1" -eq 1 ] ; then
     /bin/systemctl enable vdsmd.service >/dev/null 2>&1 || :
     /bin/systemctl enable supervdsmd.service >/dev/null 2>&1 || :
-    /bin/systemctl daemon-reload >/dev/null 2>&1 || :
 fi
+/bin/systemctl daemon-reload >/dev/null 2>&1 || :
 exit 0
 %endif
 


-- 
To view, visit http://gerrit.ovirt.org/24898
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d6e6e292494da78052a9593c5cbe94ac35ea0d9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to