Ayal Baron has posted comments on this change. Change subject: [WIP] lvm: Add an option to replace locking type 4 ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 291: self._pvs = {} Line 292: self._vgs = {} Line 293: self._lvs = {} Line 294: Line 295: def cmd(self, cmd, devices=tuple(), safe=True): > In my point of view, safe indeed sounds more like 'readonly' than 'safe to run in cluster mode'. But since it is obviously not immediately clear then name should be rwaccess or something that is unambiguous Line 296: """ Line 297: Use safe as False only for lvm cluster safe commands. Line 298: These are cmds that don't change metadata of an existing VG. Line 299: """ -- To view, visit http://gerrit.ovirt.org/23645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
