Dan Kenigsberg has posted comments on this change. Change subject: net tests: more combinations mtu combinations ......................................................................
Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/19230/3/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1194: self.assertEquals(status, SUCCESS, msg) Line 1195: self.assertNetworkExists(netName, bridged=bridged) Line 1196: self.assertBondExists(BONDING_NAME, bondDict['nics']) Line 1197: if 'mtu' in networkOpts: Line 1198: self.assertMtu(networkOpts['mtu']) with an empty *elems, this is a no-op. Line 1199: Line 1200: @cleanupNet Line 1201: @permutations([[True], [False]]) Line 1202: @RequireDummyMod -- To view, visit http://gerrit.ovirt.org/19230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7a1f5b628261ae4ebf400494bcdb2939a9cd535 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Assaf Muller <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
