Sergey Gotliv has posted comments on this change. Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25628/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 147: sd.POSIXFS_DOMAIN: 'posixfs', Line 148: sd.GLUSTERFS_DOMAIN: 'glusterfs'} Line 149: Line 150: Line 151: def _resolveIscsiIface(ifaceName, initiatorName): > Renaming this function is not related to this fix. Can you split it to sepa Sure Line 152: if not ifaceName: Line 153: return iscsi.IscsiInterface('default') Line 154: Line 155: for iface in iscsi.iterateIscsiInterfaces(): -- To view, visit http://gerrit.ovirt.org/25628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
