Sergey Gotliv has uploaded a new change for review. Change subject: iscsi: Use tpgt when login, update or remove iscsi node ......................................................................
iscsi: Use tpgt when login, update or remove iscsi node According to iscsi documentation http://www.open-iscsi.org/docs/README: Tpgt, is the portal group tag of the portal, and is not used in iscsiadm commands except for static record creation and iface name is the name of the iscsi interface defined in /etc/iscsi/ifaces. If no interface is defined in /etc/iscsi/ifaces or passed in, the default behavior is used. Default here is iscsi_tcp/tcp to be used over which ever NIC the network layer decides is best. The bottom line is that without tpgt iscsi node is connected to host only via one iface and can't perform failover when this interface lost connection to the target. Change-Id: I11a6a556d31524f4fae4786f5735accaf1cefb34 Signed-off-by: Sergey Gotliv <[email protected]> --- M vdsm/storage/iscsi.py 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/25706/1 diff --git a/vdsm/storage/iscsi.py b/vdsm/storage/iscsi.py index f4fdceb..dd5b822 100644 --- a/vdsm/storage/iscsi.py +++ b/vdsm/storage/iscsi.py @@ -144,7 +144,8 @@ def addIscsiNode(iface, target, credentials=None): targetName = target.iqn - portalStr = "%s:%d" % (target.portal.hostname, target.portal.port) + portalStr = "%s:%d,%d" % (target.portal.hostname, target.portal.port, + target.portal.group if target.portal.group else 1) with _iscsiadmTransactionLock: iscsiadm.node_new(iface.name, portalStr, targetName) try: @@ -165,7 +166,8 @@ def removeIscsiNode(iface, target): targetName = target.iqn - portalStr = "%s:%d" % (target.portal.hostname, target.portal.port) + portalStr = "%s:%d,%d" % (target.portal.hostname, target.portal.port, + target.portal.group if target.portal.group else 1) with _iscsiadmTransactionLock: try: iscsiadm.node_disconnect(iface.name, portalStr, targetName) -- To view, visit http://gerrit.ovirt.org/25706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I11a6a556d31524f4fae4786f5735accaf1cefb34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
