Dan Kenigsberg has posted comments on this change. Change subject: vm: Set numatune and guest numa topology ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25254/2/vdsm/vm.py File vdsm/vm.py: Line 1131: numa = XMLElement('numa') Line 1132: guestNumaNodes = self.conf.get('guestNumaNodes') Line 1133: for vmCell in guestNumaNodes: Line 1134: numa.appendChildWithArgs('cell', Line 1135: cpus=vmCell['cpus'].replace(";", ","), Would you explain why do we need this special handling of the semicolon? Why should we accept both colon and semicolon for the same purpose? At the least, please document this oddity in the commit message. Line 1136: memory=str(vmCell['memory'])) Line 1137: cpu.appendChild(numa) Line 1138: Line 1139: self.dom.appendChild(cpu) -- To view, visit http://gerrit.ovirt.org/25254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Xiaolei Shi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
