Douglas Schilling Landgraf has posted comments on this change. Change subject: pre-start: touch/configure vdsm logs ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25912/4/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in: Line 49: Line 50: if [ ! -e @VDSMLOGDIR@/supervdsm.log ]; then Line 51: @TOUCH_PATH@ @VDSMLOGDIR@/supervdsm.log Line 52: @CHMOD_PATH@ 0644 @VDSMLOGDIR@/supervdsm.log Line 53: @CHOWN_PATH@ root:root @VDSMLOGDIR@/supervdsm.log > I think that this will work only if script was executed by a root user. correct. I just checked that supervdsm.log is already created by supervdsm daemon which is running after rhev-h install. We can avoid this validation. Line 54: fi Line 55: } Line 56: Line 57: task_run_init_hooks(){ -- To view, visit http://gerrit.ovirt.org/25912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca927cb447eeb24195cff6a1174e0f9a7295214 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Ryan Barry <rba...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
