Dan Kenigsberg has posted comments on this change. Change subject: tools: configurator must persist usermod changes ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25974/4//COMMIT_MSG Commit Message: Line 7: tools: configurator must persist usermod changes Line 8: Line 9: vdsm-tool configure --force adds to /etc/group (qemu/kvm) sanlock Line 10: but doesn't persist the file in ovirt node distro which will Line 11: affect vdsm start on next reboot. The goal for this patch is persist Please explain what are exactly the effect on vdsm start. Couldn't we instead just call the relevant usermod command on the rpm's %pre? Line 12: the /etc/group in case vdsm-tool is running on ovirt-node. Line 13: Line 14: Change-Id: Id4a7dea08bac41ff557aa52826463f2bdf481562 -- To view, visit http://gerrit.ovirt.org/25974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4a7dea08bac41ff557aa52826463f2bdf481562 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
