Dan Kenigsberg has posted comments on this change. Change subject: configurator: move usermod to spec ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/26055/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 114: def getName(self): Line 115: return 'sanlock' Line 116: Line 117: def getServices(self): Line 118: return ['sanlock'] we cannot just drop "configure". Non-rpm installation may depend on it; if it's gone, there's no much point in keeping SanlockModuleConfigure. Line 119: Line 120: def isconfigured(self): Line 121: """ Line 122: True if sanlock service is configured, False if sanlock service http://gerrit.ovirt.org/#/c/26055/1/vdsm.spec.in File vdsm.spec.in: Line 733: /bin/systemctl daemon-reload >/dev/null 2>&1 || : Line 734: exit 0 Line 735: %endif Line 736: Line 737: %preun These should happen on %posun, after all files with this ownership are removed, and only there are no more copies of vdsm installed (if [ "$1" -eq 0 ]). Line 738: /usr/bin/gpasswd -d %{snlk_user} %{qemu_group} Line 739: /usr/bin/gpasswd -d %{snlk_user} %{vdsm_group} Line 740: Line 741: if [ "$1" -eq 0 ]; then -- To view, visit http://gerrit.ovirt.org/26055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
