Yaniv Bronhaim has posted comments on this change. Change subject: clientIF: Clean up shutdown process ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26112/1/vdsm/vdsm File vdsm/vdsm: Line 77: cif = clientIF.getInstance(irs, log) Line 78: cif.start() Line 79: try: Line 80: while running[0]: Line 81: signal.pause() just be sure that this jumps only after the sigtermHandler code is done. otherwise we won't call prepareForShutdown ever. and except that, if prepareForShutdown is called from somewhere else (i see prepareForShutdown api) ? you need to signal yourself to exit normally , and it will call prepareForShutdown again .. Line 82: finally: Line 83: cif.prepareForShutdown() Line 84: Line 85: -- To view, visit http://gerrit.ovirt.org/26112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7bfa9f7da81ffdfb581299cd14ec4edb50be5fb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
