Francesco Romani has posted comments on this change. Change subject: Create GuestAgent instance in __init__ and connect later ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26142/1//COMMIT_MSG Commit Message: Line 8: Line 9: This is not only a cosmetic improvement. There are cases where we Line 10: are trying to call methods of the GuestAgent before the instance was Line 11: created. To avoid these race conditions we're creating the instance of Line 12: the guest agent already in the __init__ phase. Makes sense to me and looks like an improvement, but, not being so much familiar with this code, I wonder: what happens if we try to call methods to a GuestAgent instance not yet connected? There can be nasty consequences? Line 13: Line 14: Change-Id: I82f7397b01bff48a3c635eee9912cc67cf722b13 -- To view, visit http://gerrit.ovirt.org/26142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82f7397b01bff48a3c635eee9912cc67cf722b13 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
