Liron Ar has posted comments on this change. Change subject: core: fixing attribute error on fenceSpmStorage ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/26358/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 3529: se.SpmFenceError("spUUID=%s, lastOwner=%s, lastLver=%s" % Line 3530: (spUUID, lastOwner, lastLver))) Line 3531: pool = self.getPool(spUUID) Line 3532: if isinstance(pool.getBackend(), StoragePoolDiskBackend): Line 3533: pool.getBackend().invalidateMetadata() already wrote about that in the commit message - but just so reviewers will notice - nicer way might be to add it to the "Storage pool backend" interface and implement it for all the "interface" implementations and add invalidateMetadata() method in sp.py that'll refer there so we could leave the code here as is - i don't mind to implement either of the soltions, just let me know what you prefer. Line 3534: vars.task.getExclusiveLock(STORAGE, spUUID) Line 3535: pool.forceFreeSpm() Line 3536: return dict(spm_st=self._getSpmStatusInfo(pool)) Line 3537: -- To view, visit http://gerrit.ovirt.org/26358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
