Francesco Romani has uploaded a new change for review.

Change subject: pep8: vdsm cleanups for pep-1.5.x
......................................................................

pep8: vdsm cleanups for pep-1.5.x

vdsm/*.py is now pep8 1.5.x clean.

Change-Id: I43aec2d5c9d32f816813f575876cd458cc53b886
Signed-off-by: Francesco Romani <[email protected]>
---
M vdsm/API.py
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/26382/1

diff --git a/vdsm/API.py b/vdsm/API.py
index d075271..94b39b6 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -180,9 +180,9 @@
                 vmParams['restoreState'], paramFilespec = \
                     self._getHibernationPaths(vmParams.pop('hiberVolHandle'))
                 try:   # restore saved vm parameters
-                # NOTE: pickled params override command-line params. this
-                # might cause problems if an upgrade took place since the
-                # parmas were stored.
+                    # NOTE: pickled params override command-line params. this
+                    # might cause problems if an upgrade took place since the
+                    # parmas were stored.
                     fname = self._cif.prepareVolumePath(paramFilespec)
                     try:
                         with file(fname) as f:
@@ -218,7 +218,7 @@
                                                   ['status']['code'],
                                    'message': 'Must specify nonzero memSize'}}
 
-            if vmParams.get('boot') == 'c' and not 'hda' in vmParams \
+            if vmParams.get('boot') == 'c' and 'hda' not in vmParams \
                     and not vmParams.get('drives'):
                 return {'status': {'code': errCode['MissParam']
                                                   ['status']['code'],
@@ -1514,8 +1514,8 @@
         if not haClient:
             return errCode['unavail']
 
-        self.log.info("Setting Hosted Engine HA {0} maintenance to {1}"
-            .format(mode.lower(), enabled))
+        self.log.info("Setting Hosted Engine HA %s maintenance to %s",
+                      mode.lower(), enabled)
         if mode.lower() == 'global':
             mm = haClient.HAClient.MaintenanceMode.GLOBAL
         elif mode.lower() == 'local':


-- 
To view, visit http://gerrit.ovirt.org/26382
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43aec2d5c9d32f816813f575876cd458cc53b886
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to