Federico Simoncelli has posted comments on this change. Change subject: virt: migration: use contextmanager for monitor ......................................................................
Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/25978/15/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 61: self._tunneled = utils.tobool(tunneled) Line 62: self._abortOnError = utils.tobool(abortOnError) Line 63: self._dstqemu = dstqemu Line 64: self._downtime = int(kwargs.get('downtime') or Line 65: config.get('vars', 'migration_downtime')) Minor: I suppose this change (moving "int" here) could be split out. Line 66: self.status = { Line 67: 'status': { Line 68: 'code': 0, Line 69: 'message': 'Migration in progress'}, -- To view, visit http://gerrit.ovirt.org/25978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
