Michal Skrivanek has posted comments on this change. Change subject: pad memory volume only when the storage domain is file based ......................................................................
Patch Set 3: -Code-Review (1 comment) http://gerrit.ovirt.org/#/c/26407/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3550: if sdType == sd.NFS_DOMAIN: Line 3551: oop.getProcessPool(sdUUID).fileUtils. \ Line 3552: padToBlockSize(memoryVolPath) Line 3553: else: Line 3554: fileUtils.padToBlockSize(memoryVolPath) > Note this line was here in the original code as well - let's fix the wrong we need the actual type then. I'd go with "no OOP" altogether. It doesn't make much sense in fact - if we got here it means the QEMU finished writing GBs of data to the very same volume, we just want to add few more bytes…it's quite likely we won't block. Other alternative is to always do OOP which seems to me an overkill Line 3555: Line 3556: snap = xml.dom.minidom.Element('domainsnapshot') Line 3557: disks = xml.dom.minidom.Element('disks') Line 3558: newDrives = {} -- To view, visit http://gerrit.ovirt.org/26407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cebdbba2cc763963b64dcbc142f979802f18c16 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
