Sandro Bonazzola has uploaded a new change for review.

Change subject: packaging: add vdsm user to cdrom group
......................................................................

packaging: add vdsm user to cdrom group

Allow to boot VMs from host CD-ROM.

Change-Id: I44d842e7b1df073c33284b51185e29ce0d02a0e0
Bug-Url: https://bugzilla.redhat.com/1082028
Signed-off-by: Sandro Bonazzola <[email protected]>
---
M configure.ac
M debian/vdsm.postinst
M vdsm.spec.in
3 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/26541/1

diff --git a/configure.ac b/configure.ac
index a6382c4..994a674 100644
--- a/configure.ac
+++ b/configure.ac
@@ -118,6 +118,7 @@
 AC_SUBST([METADATAGROUP], [kvm])
 AC_SUBST([SNLKUSER], [sanlock])
 AC_SUBST([SNLKGROUP], [sanlock])
+AC_SUBST([CDROMGROUP], [cdrom])
 
 # VDSM default paths
 AC_SUBST([vdsmdir], ['${datarootdir}/vdsm'])
diff --git a/debian/vdsm.postinst b/debian/vdsm.postinst
index bc10dc6..8515855 100644
--- a/debian/vdsm.postinst
+++ b/debian/vdsm.postinst
@@ -23,6 +23,7 @@
 SNLK_GROUP=sanlock
 SNLK_USER=sanlock
 LIBVIRT_SOCK_GROUP=libvirtd
+CDROM_GROUP=cdrom
 
 INSTALLDIR="install -dDm 0755 -o $VDSM_USER -g $VDSM_GROUP"
 
@@ -33,7 +34,8 @@
             -s /usr/sbin/nologin -c "Node Virtualization Manager" "$VDSM_USER"
         #getent passwd "$SNLK_USER" >/dev/null || useradd -r -g "$SNLK_GROUP" \
         #    -s /bin/false -c "sanlock service" "$SNLK_USER"
-        usermod -a -G "$QEMU_GROUP","$SNLK_GROUP","$LIBVIRT_SOCK_GROUP" 
"$VDSM_USER"
+        usermod -a -G "$QEMU_GROUP","$SNLK_GROUP","$LIBVIRT_SOCK_GROUP" \
+            "$CDROM_GROUP" "$VDSM_USER"
         usermod -a -G "$QEMU_GROUP","$VDSM_GROUP" "$SNLK_USER"
 
         start_conf_section="## beginning of configuration section by vdsm"
diff --git a/vdsm.spec.in b/vdsm.spec.in
index e1d6d40..7c42381 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -9,6 +9,7 @@
 %global qemu_group @QEMUGROUP@
 %global snlk_group @SNLKGROUP@
 %global snlk_user @SNLKUSER@
+%global cdrom_group @CDROMGROUP@
 
 # Fedora official build
 %global fedora_koji_build 0
@@ -689,7 +690,7 @@
 /usr/bin/getent passwd %{vdsm_user} >/dev/null || \
     /usr/sbin/useradd -r -u 36 -g %{vdsm_group} -d /var/lib/vdsm \
         -s /sbin/nologin -c "Node Virtualization Manager" %{vdsm_user}
-/usr/sbin/usermod -a -G %{qemu_group},%{snlk_group} %{vdsm_user}
+/usr/sbin/usermod -a -G %{qemu_group},%{snlk_group},%{cdrom_group} %{vdsm_user}
 
 %post
 %{_bindir}/vdsm-tool configure --module sanlock --force


-- 
To view, visit http://gerrit.ovirt.org/26541
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I44d842e7b1df073c33284b51185e29ce0d02a0e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to