Hello Douglas Schilling Landgraf, Nir Soffer, Federico Simoncelli, Allon
Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/26657
to review the following change.
Change subject: hsm: Rename _BCInitiatorNameResolve function
......................................................................
hsm: Rename _BCInitiatorNameResolve function
Function _BCInitiatorNameResolve actually resolves the iface name not
the initiator name so new name emphasizes that.
Change-Id: I716317afdba3321c9d6bf0e382f261b3b22802f7
Signed-off-by: Sergey Gotliv <[email protected]>
Reviewed-on: http://gerrit.ovirt.org/25701
Reviewed-by: Nir Soffer <[email protected]>
Reviewed-by: Allon Mureinik <[email protected]>
Reviewed-by: Federico Simoncelli <[email protected]>
Reviewed-by: Douglas Schilling Landgraf <[email protected]>
---
M vdsm/storage/hsm.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/26657/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 2296448..c740ec8 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -148,7 +148,7 @@
sd.GLUSTERFS_DOMAIN: 'glusterfs'}
-def _BCInitiatorNameResolve(ifaceName, initiatorName):
+def _resolveIscsiIface(ifaceName, initiatorName):
if not ifaceName:
return iscsi.IscsiInterface('default')
@@ -230,8 +230,8 @@
target = iscsi.IscsiTarget(portal, tpgt, conDict.get('iqn', None))
- iface = _BCInitiatorNameResolve(conDict.get('ifaceName', None),
- conDict.get('initiatorName', None))
+ iface = _resolveIscsiIface(conDict.get('ifaceName', None),
+ conDict.get('initiatorName', None))
cred = None
username = conDict.get('user', None)
--
To view, visit http://gerrit.ovirt.org/26657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I716317afdba3321c9d6bf0e382f261b3b22802f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
